Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional dependency load #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add optional dependency load #2

wants to merge 2 commits into from

Conversation

danschultzer
Copy link
Collaborator

@danschultzer danschultzer commented Aug 4, 2018 •
edited
Loading

I'm not 100% sure if this is the best way to handle the optional dependency. It seems to fail in umbrella setups.

Also, there'll be some warnings like the following:

warning: function Mix.Tasks.Pow.Ecto.Install.run/1 is undefined (module Mix.Tasks.Pow.Ecto.Install is not available)
  lib/mix/tasks/pow.install.ex:35

warning: function Mix.Tasks.Pow.Phoenix.Install.run/1 is undefined (module Mix.Tasks.Pow.Phoenix.Install is not available)
  lib/mix/tasks/pow.install.ex:41

warning: function Pow.Ecto.Context.authenticate/2 is undefined (module Pow.Ecto.Context is not available)
  lib/pow/operations.ex:22

warning: function Pow.Ecto.Context.create/2 is undefined (module Pow.Ecto.Context is not available)
  lib/pow/operations.ex:30

warning: function Pow.Ecto.Context.delete/2 is undefined (module Pow.Ecto.Context is not available)
  lib/pow/operations.ex:46

warning: function Pow.Ecto.Context.get_by/2 is undefined (module Pow.Ecto.Context is not available)
  lib/pow/operations.ex:54

warning: function Pow.Ecto.Context.update/3 is undefined (module Pow.Ecto.Context is not available)
  lib/pow/operations.ex:38

I'll clean this up once I've decided if this PR is the right way to handle optional deps.

@danschultzer danschultzer force-pushed the optional-deps branch 2 times, most recently from bd8acbd to fca3db5 Compare August 11, 2018 02:59
@danschultzer danschultzer force-pushed the optional-deps branch 4 times, most recently from 886900d to ae30c1c Compare August 12, 2018 17:18
@danschultzer danschultzer force-pushed the optional-deps branch 2 times, most recently from 2705464 to effe15c Compare March 9, 2019 17:53
@danschultzer danschultzer mentioned this pull request Mar 13, 2019
Merged
@danschultzer danschultzer mentioned this pull request Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danschultzer