Better mix error handling #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
better-mix-error-handling
branch
4 times, most recently
from
659f2ca
to
781354d
Compare
danschultzer
force-pushed
the
better-mix-error-handling
branch
from
781354d
to
f584028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to messages and handling of errors.
Now top level dependency requirement for ecto or phoenix rather than accept inclusion from another dependency since Pow will always include ecto and phoenix. This can be removed again if I get #2 working, however, umbrella apps will include all dependencies from other apps so it should probably be reworked at that time.