Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xm device #50

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

haixuanTao
Copy link
Contributor

Note that this was generated using ChatGPT 4

https://chat.openai.com/share/bbb2a8d4-ede4-4101-909b-106c9df5570b

I have checked most of the address for hallucination and I'm able to read and write with it. But there might be some hallucinations.

@pierre-rouanet
Copy link
Member

Thanks for your contribution!
I don't have any xm motors to check but it looks good to me!

Can you remove the modification from #51 in this PR though?

@haixuanTao
Copy link
Contributor Author

Okay sure!

Removed the commit.

@@ -0,0 +1,62 @@
//! MX robotis register (protocol v1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the documentation?

@pierre-rouanet pierre-rouanet merged commit 6a4b45e into pollen-robotics:develop May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants