added script to dismiss reviews #76
Conversation
|
/merge |
There was a problem running the action.❌😵❌ Please find more information in the logs. |
Ah yeah, I forgot that actions can not merge PRs which modify workflows |
|
@Bullrich and this works as well for external reviews? |
Yes, I tried it in Bullrich/auto-merge-bot#2 where @rzadp is not a member and the system dismissed his PR |
|
/merge |
There was a problem running the action.❌😵❌ Please find more information in the logs. |
|
/merge |
|
Enabled Available commands
For more information see the documentation |
|
/merge cancel |
|
Disabled Available commands
For more information see the documentation |
|
I'm a bit stuck with this one, as it will discard reviews when the branch gets updated with the "Keep branch up to date" action (or by pressing the button). I'm researching into differentiating this kind of push from regular pushes. |
|
@Bullrich ^^ |
Hi @ggwpez, After a very long process I was finally able to make a final version work. I modified the code to work in the same way as paritytech/polkadot-sdk#4152 and paritytech/polkadot-sdk#3431, so now it only requires that the last commit is reviewed, but it doesn't require this for fellows. It also doesn't dismiss reviews on merge commits if the commit is made by the merge-bot or a fellow. Please, take another look to the PR and let me know if it satisfies your requirements. Thanks! |
Bullrich
force-pushed
the
dismiss-reviews
branch
from
f7dc85a to
6ef0844
Compare
This stops the dismissal on different events and only executes it when the user pushes new commits to the PR
It should not be a separated step
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit 633d4e7
into
polkadot-fellows:main
Added a script that will require new reviews in a PR if the author (who is not a fellow) pushed a new commit.
Resolves #60
Copied from paritytech/polkadot-sdk#4152 and paritytech/polkadot-sdk#3431
Summary
Added a new step in the action that triggers review bot to stop approval from new pushes.
This step works in the following way:
It does not dismiss reviews. It simply request them again, but they will still be available.
This way, if the author changed something in the code, they will still need to have this latest change approved to stop them from uploading malicious code.