Dismiss approval on new changes #60
Comments
|
@Bullrich can you take care of this? |
|
Hi @bkchr, this is a check that can be enabled at the branch protection settings:
|
|
Ahh nice! Then I will enable this. Ty! |
|
Done |
|
Okay, that is actually not working. This only removes approvals from people who approval rights in the repo. Thus, anyone outside approval isn't removed. |
I did not know that. I will make a small action to handle this then 🙂 |
|
@bkchr find PR with the requested feature: |
fellowship-merge-bot bot
pushed a commit
that referenced
this issue
May 7, 2024
Added a script that will require new reviews in a PR if the author (who is not a fellow) pushed a new commit. Resolves #60 Copied from paritytech/polkadot-sdk#4152 and paritytech/polkadot-sdk#3431 ## Summary Added a new step in the action that triggers review bot to stop approval from new pushes. This step works in the following way: - If the **author of the PR**, who **is not** a fellow, pushed a new commit then: - Review-Trigger requests new reviews from the reviewers and fails. It *does not dismiss reviews*. It simply request them again, but they will still be available. This way, if the author changed something in the code, they will still need to have this latest change approved to stop them from uploading malicious code. - [x] Does not require a CHANGELOG entry
|
@bkchr this can be closed already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do we want to dismiss approval on PR on new changes? Otherwise the PR author can change the PR to something else and merge it.
The text was updated successfully, but these errors were encountered: