Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migrations and add migration CI checks #75
Fix migrations and add migration CI checks #75
Changes from 16 commits
8efa467
a00667a
f591de6
a79a71f
7ff8976
5bead26
6b887ee
a9b92b1
195adf5
6e9fa9b
9decbb3
2af7445
e988576
becded4
7076cc1
e0e85ff
d820719
a8baeec
e8599fe
c7896aa
f0bf2af
0ee8b34
e22f759
79255f8
d5d1bc7
bf099db
ab90c7e
6bbd9d4
13d175e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We not all checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The disabled checks here are try-state invariants. I still need to test those on all chains to make sure they pass. Don't want to turn it on yet just in case there're some jobs fail when in reality everything about the migrations is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also first create a snap and then once run with all checks and once with only pre-and-post. The first one would only be good for logging, not erroring.
This file was deleted.