Fix migrations and add migration CI checks #75
Conversation
liamaharon
changed the title
liamaharon
changed the title
| fi | ||
| ./try-runtime \ | ||
| --runtime ./${{ matrix.runtime.path }}/target/srtool/production/wbuild/$PACKAGE_NAME/$RUNTIME_BLOB_NAME \ | ||
| on-runtime-upgrade --checks=pre-and-post $NO_WEIGHT_WARNINGS_FLAG live --uri ${{ matrix.runtime.uri }} |
There was a problem hiding this comment.
The disabled checks here are try-state invariants. I still need to test those on all chains to make sure they pass. Don't want to turn it on yet just in case there're some jobs fail when in reality everything about the migrations is fine.
There was a problem hiding this comment.
You could also first create a snap and then once run with all checks and once with only pre-and-post. The first one would only be good for logging, not erroring.
|
fyi the error with Asset Hub Kusama will be fixed when this commit lands in the runtime. |
| fi | ||
| ./try-runtime \ | ||
| --runtime ./${{ matrix.runtime.path }}/target/srtool/production/wbuild/$PACKAGE_NAME/$RUNTIME_BLOB_NAME \ | ||
| on-runtime-upgrade --checks=pre-and-post $NO_WEIGHT_WARNINGS_FLAG live --uri ${{ matrix.runtime.uri }} |
There was a problem hiding this comment.
You could also first create a snap and then once run with all checks and once with only pre-and-post. The first one would only be good for logging, not erroring.
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
|
Thank you for the reviews :) I will fix the failing migrations, then this will be ready to merge. |
Co-authored-by: ordian <[email protected]>
liamaharon
changed the title
liamaharon
changed the title
Closes #70
The error with Asset Hub Kusama will be fixed when this commit lands in the runtime.