@aliases Endpoint #1398
@aliases Endpoint #1398
Conversation
|
@Petchesi-Iulian thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…estapi into alias_controlpanel
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
* Initial commit. * Added GET root endpoint. * Added @Aliases root POST * Refs #1393 - Add @Aliases endpoint docs * Flake8 & delete endpoint * Black Co-authored-by: Alin Voinea <[email protected]>
|
@jenkins-plone-org please run jobs |
| self.request.response.setStatus(201) | ||
|
|
||
| self.request.form["b_start"] = "0" | ||
| self.request.form["b_size"] = "1000000" |
There was a problem hiding this comment.
I am wondering if we shouldn't go the extra mile of implementing batching here. I can imagine that the number of redirects can become quite significant even on mid-size websites.
There was a problem hiding this comment.
@tisto Do you suggest to set the default b_size to 50?
|
@jenkins-plone-org please run jobs |
|
@fredvd Are the failing jenkins test still not-related to this PR or it's a real issue? |
|
@jenkins-plone-org please run jobs |
@avoinea These are not related to this PR, there are still a few flakey robot tests left on plone.schema editor and the generic Fields robot tests that fail occasionally. Those are also failing in other tests. I was fumbling around a bit to check the failures/success for this specific PR on the Pull request jobs on jenkins, just learned you can paste the PR URL in the filter on the PR job page to see them:
|
|
@avoinea The robot tests are now zero, but other 'normal' tests fail. |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@Petchesi-Iulian @avoinea just wondering. The current @Aliases endpoint does not allow filtering by aliases that have been added manually or automatically, is that correct? |
|
@tisto Yes, I think you're right. There is no way to filter them by the |
|
@avoinea thanks for the feedback! I created an issue for this: I also noticed that we do not have any way to filter for a date range. I also created a ticket for this: We should also add the functionality to upload/download aliases as CSV file: Once we have the REST API endpoints in place, we could enhance the Volto URL control panel to expose this new functionality. Are you folks interested in those functionalities? We (at kitconcept) are currently working with the ClassicUI controlpanel but this is not a long-term solution. Therefore I'd love to see if we would catch up with Volto. |
For #1393