Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aliases endpoint should allow to upload/download all aliases and allow to download filtered aliases as CSV file #1793

Closed
tisto opened this issue Jun 15, 2024 · 0 comments · Fixed by #1813
Assignees

Comments

@tisto
Copy link
Member

tisto commented Jun 15, 2024

PR for adding aliases: #1398

The @Aliases should allow to upload aliases as CSV files and to download all existing aliases as CSV file. I am guessing there is a browser view in ClassicUI that does this already. Therefore it should be pretty straight forward to add this to the existing controlpanel.

However, it would be nice if we would allow to download a CSV file based on any filter criterion of the @Aliases endpoint:

http://localhost:8080/Plone/++api++/@aliases&q=/de/ft/my-path&manual=true&from=2021-01-01&to=2023-01-01

We could use content negotiation for this and send the "Accept" HTTP header "text/csv". Then REST API would return the CSV file.

Code

Download method of the redirects control panel:

https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/controlpanel/browser/redirects.py#L457

There is not a single unit/integration test for the aliases service. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants