-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev containers support for VS Code and GitHub Codespaces #970
base: 6.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if CODESPACE_NAME: | ||
DOMAIN = os.environ["GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN"] | ||
hostname = f"{CODESPACE_NAME}-8080.{DOMAIN}" | ||
app.virtual_hosting.set_map(f"localhost:8080/VirtualHostBase/https/{hostname}:443/VirtualHostRoot") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is app a global variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiru Yes, for scripts run with zope's zconsole run
command. I'll probably clean this up a bit...just a proof of concept so far
I am testing it and the build process took me several minutes (in the first run). Looks too slow for using in a training with slow internet connection. |
I did clone the repo. '''
Can not execute action!
Can not execute action!
Cloned 'docs' with git using branch '6.0' from 'https://github.com/plone/documentation.git'. |
@ramiroluz Thanks for testing it.
This is a scenario where it might make more sense to use the dev container in a GitHub Codespace. Then most of the network transfer is to the remote VM that runs the software, rather than to your own device. The "fatal: detected dubious ownership" error might happen if you already had some repositories cloned in the src folder before you started the dev container (because the owner outside the container is different than the user inside the container). I'll check how we can avoid this error. |
Proof of concept.
To do: