Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev containers support for VSCode #969

Closed
wants to merge 3 commits into from
Closed

Dev containers support for VSCode #969

wants to merge 3 commits into from

Conversation

xiru
Copy link
Member

@xiru xiru commented Nov 30, 2024

Add initial support for dev containers on VS Code.

@xiru xiru requested a review from davisagli November 30, 2024 14:31
@xiru xiru marked this pull request as draft November 30, 2024 14:35
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiru Thanks for running with this while I was discussing docs with the GSOC students. Here are a couple things I think we'll need to update. Come grab me if you want to discuss.

},

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "pip3 install --user -r requirements.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiru We should run make install here. This takes care of some other steps that build the requirements file to include some packages from github (for the packages that have unreleased changes).

We'll need a base image that includes tools like make, git, and ssh.

@xiru
Copy link
Member Author

xiru commented Nov 30, 2024

@davisagli added a script to run the buildout as part of the dev container creation. Now we should be OK. Tested in my laptop and it worked as expected, environment was created, vc code sends a notification about the service running, you click it and opens a browset in you local machine, connecting localhost:8080 and it actually connects the 8080 port inside the container.

@xiru xiru marked this pull request as ready for review November 30, 2024 18:30
@davisagli
Copy link
Member

Closing in favor of #970, which uses make install and fixes the virtual hosting

@davisagli davisagli closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants