This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
fix: pma textures are requested to be loaded as already premultiplied #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Spine atlas txt files that are generate in conjunction with the respective atlas textures contains a
pma
option that holds the information regarding the textures beinga premultiplied or not.This information can be used to inform the texture loader to premultiply or not the texture on load.
This PR allows to use the
pma
information and to request to the pixi texture loader to premultiply the texture or not.When
webgpu
is used, this is sufficient.However, when
webgl
is used, it is necessary to set onPIXI.Assets
thepreferWorkers
tofalse
when Spine premultiplied textures are loaded because currently whencreateImageBitmap
is used, the givenalphaMode
is ignored. This can be avoided if this other PR is merged: pixijs/pixijs#10803If this PRs are merged, it would be cool if the blog news examples would be regenerated to use this fix. Currently, all textures have the problem of using pma textures, but are loaded without taking this in consideration.