-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prettier to 3.3.3 and reformat files #9503
Conversation
@@ -21,6 +21,12 @@ repos: | |||
rev: v3.1.0 | |||
hooks: | |||
- id: prettier | |||
additional_dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change is here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9503 +/- ##
==========================================
+ Coverage 74.24% 75.80% +1.55%
==========================================
Files 1332 1422 +90
Lines 40817 42916 +2099
Branches 7634 7900 +266
==========================================
+ Hits 30306 32531 +2225
+ Misses 10511 10385 -126 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testsmsedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
@@ -225,7 +225,7 @@ function setVarsFromSchema({ | |||
const nodePath = [...parentPath, key]; | |||
|
|||
const existence = | |||
existenceOverride ?? required?.includes(key) | |||
(existenceOverride ?? required?.includes(key)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of this prettier change
This comment has been minimized.
This comment has been minimized.
@@ -25,9 +25,9 @@ | |||
"npm": "10.5.0" | |||
}, | |||
"devDependencies": { | |||
"knip": "^5.36.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep these sorted
@@ -4,7 +4,7 @@ coverage | |||
|
|||
# ignore libraries | |||
node_modules | |||
public/mockServiceWorker.js | |||
**/public/mockServiceWorker.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fungairino @grahamlangford we'll want to consider workspace-specific prettierignore
and gitignore
files
Exactly. Remember when we had to commit, add, commit in order to satisfy the prettier step in pre-commit? Making prettier a devDependency ensured that pre-commit and local format-on-save agreed See: #7553 |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
Discussion
Future Work
For more information on our expectations for the PR process, see the
code review principles doc