Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier to 3.3.3 and reformat files #9503

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Nov 12, 2024

What does this PR do?

  • Bump prettier to 3.3.3 and run against all files
  • See linked code

Discussion

  • Do we need prettier as an npm dev dependency? Do people's IDEs use that if they have it configured (or does that functionality use npx)?

Future Work

  • Create a job to automatically bump prettier and run over all files

For more information on our expectations for the PR process, see the
code review principles doc

@@ -21,6 +21,12 @@ repos:
rev: v3.1.0
hooks:
- id: prettier
additional_dependencies:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change is here

@twschiller twschiller self-assigned this Nov 12, 2024
@twschiller twschiller added dependencies Pull requests that update a dependency file and removed developer experience labels Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (8318d74) to head (666e944).
Report is 504 commits behind head on main.

Files with missing lines Patch % Lines
...browser-extension/src/testUtils/permissionsMock.ts 0.00% 4 Missing ⚠️
...ields/schemaFields/widgets/DatabaseCreateModal.tsx 0.00% 2 Missing ⚠️
...elds/schemaFields/widgets/varPopup/SourceLabel.tsx 0.00% 2 Missing ⚠️
...xtension/src/components/MarketplaceListingIcon.tsx 0.00% 1 Missing ⚠️
...ionConsole/pages/packageEditor/useSubmitPackage.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9503      +/-   ##
==========================================
+ Coverage   74.24%   75.80%   +1.55%     
==========================================
  Files        1332     1422      +90     
  Lines       40817    42916    +2099     
  Branches     7634     7900     +266     
==========================================
+ Hits        30306    32531    +2225     
+ Misses      10511    10385     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 12, 2024

Playwright test results

passed  153 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  10 minutes, 46 seconds
commit  666e944
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@@ -225,7 +225,7 @@ function setVarsFromSchema({
const nodePath = [...parentPath, key];

const existence =
existenceOverride ?? required?.includes(key)
(existenceOverride ?? required?.includes(key))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of this prettier change

@twschiller twschiller added the javascript Pull requests that update Javascript code label Nov 12, 2024

This comment has been minimized.

@@ -25,9 +25,9 @@
"npm": "10.5.0"
},
"devDependencies": {
"knip": "^5.36.7",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep these sorted

@@ -4,7 +4,7 @@ coverage

# ignore libraries
node_modules
public/mockServiceWorker.js
**/public/mockServiceWorker.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fungairino @grahamlangford we'll want to consider workspace-specific prettierignore and gitignore files

@twschiller twschiller changed the title Bump prettier to 3.3.3 Bump prettier to 3.3.3 and reformat all files Nov 13, 2024
@twschiller twschiller changed the title Bump prettier to 3.3.3 and reformat all files Bump prettier to 3.3.3 and reforma files Nov 13, 2024
@twschiller twschiller changed the title Bump prettier to 3.3.3 and reforma files Bump prettier to 3.3.3 and reformat files Nov 13, 2024
@grahamlangford
Copy link
Collaborator

grahamlangford commented Nov 13, 2024

Do we need prettier as an npm dev dependency? Do people's IDEs use that if they have it configured (or does that functionality use npx)?

Exactly. Remember when we had to commit, add, commit in order to satisfy the prettier step in pre-commit? Making prettier a devDependency ensured that pre-commit and local format-on-save agreed

See: #7553

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller added this to the 2.2.0 milestone Nov 13, 2024
@twschiller twschiller merged commit 4712baa into main Nov 13, 2024
31 checks passed
@twschiller twschiller deleted the feature/bump-pre-commit-3.3.3 branch November 13, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file developer experience javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

2 participants