-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9457: move knip
to repository root
#9505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9505 +/- ##
==========================================
+ Coverage 74.24% 75.81% +1.57%
==========================================
Files 1332 1413 +81
Lines 40817 42769 +1952
Branches 7634 7881 +247
==========================================
+ Hits 30306 32427 +2121
+ Misses 10511 10342 -169 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
@@ -283,7 +278,6 @@ | |||
"node-polyfill-webpack-plugin": "^4.0.0", | |||
"otpauth": "^9.3.4", | |||
"path-browserify": "^1.0.1", | |||
"prettier": "3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion: #9503
knip
to rootknip
to repository root
knip
to repository rootknip
to repository root
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Looks like knip is still warning of a few more things we need to handle in the CI run. |
knip
to repository rootknip
to repository root
Yep, needed to fill out more of the package.json:
|
What does this PR do?
Remaining Work
Future Work
For more information on our expectations for the PR process, see the
code review principles doc