Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9457: move knip to repository root #9505

Merged
merged 8 commits into from
Nov 12, 2024
Merged

#9457: move knip to repository root #9505

merged 8 commits into from
Nov 12, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Nov 12, 2024

What does this PR do?

Remaining Work

  • Fix relative directory reference from storybook/webpack.sharedConfig.js
  • Fix knip results (it looks like it's not picking up the knip config in the workspace)
  • Verify production mode works locally
  • Update CI commands
  • Fix knip configuration for libraries workspace
  • Verify CI commands

Future Work

  • Update CI to run lint on all workspaces

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (8318d74) to head (26dc6f0).
Report is 489 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9505      +/-   ##
==========================================
+ Coverage   74.24%   75.81%   +1.57%     
==========================================
  Files        1332     1413      +81     
  Lines       40817    42769    +1952     
  Branches     7634     7881     +247     
==========================================
+ Hits        30306    32427    +2121     
+ Misses      10511    10342     -169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 12, 2024

Playwright test results

passed  154 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  10 minutes, 53 seconds
commit  26dc6f0
info  For more information on how to debug and view this report, see our readme

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@@ -283,7 +278,6 @@
"node-polyfill-webpack-plugin": "^4.0.0",
"otpauth": "^9.3.4",
"path-browserify": "^1.0.1",
"prettier": "3.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion: #9503

@twschiller twschiller changed the title #9457: [WIP] move knip to root #9457: move knip to root Nov 12, 2024
@twschiller twschiller marked this pull request as ready for review November 12, 2024 15:45
@twschiller twschiller changed the title #9457: move knip to root #9457: move knip to repository root Nov 12, 2024
@twschiller twschiller added this to the 2.2.0 milestone Nov 12, 2024
@twschiller twschiller marked this pull request as draft November 12, 2024 15:49
@twschiller twschiller changed the title #9457: move knip to repository root #9457: [WIP] move knip to repository root Nov 12, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fungairino
Copy link
Collaborator

Looks like knip is still warning of a few more things we need to handle in the CI run.

@twschiller twschiller changed the title #9457: [WIP] move knip to repository root #9457: move knip to repository root Nov 12, 2024
@twschiller
Copy link
Contributor Author

Looks like knip is still warning of a few more things we need to handle in the CI run.

Yep, needed to fill out more of the package.json:

"lint": "npm run lint:full -- --rule '{\"import/no-cycle\": \"off\"}'",

@twschiller twschiller marked this pull request as ready for review November 12, 2024 16:05
@twschiller twschiller enabled auto-merge (squash) November 12, 2024 16:05
@twschiller twschiller merged commit 971d00b into main Nov 12, 2024
22 checks passed
@twschiller twschiller deleted the feature/9457-knip-root branch November 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Run knip script from the root project package.json
3 participants