Several fixes and merge conflicts resolved #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te/treasury-management/ach-conversion/ACH-File-Specifications.pdf, "All alphabetic characters must be in upper case"
Conflicts: src/Nacha/Field/Number.php src/Nacha/File.php src/Nacha/Record/FileFooter.php src/Nacha/Record/FileHeader.php
… into merge-kulparoman-pr6
…ss to contain debits and credits for all types. Fixes philipwhitt#10
|
@jdforsythe Sorry I let this sit so long - would you like to fix the conflicts and I'll merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8 - introduced by #5
Fixes conflicts to merge #6
Proper RegEx for valid ACH ASCII range
Modified multiline strings in tests so the tests will run properly on Windows (files get line endings converted to CRLF, so forced
\nline endings for the test strings)The original project incorrectly assumes that credit entries = CCD entries and vice versa, where in reality CCD can be credit or debit, and other types (like PPD) can be credit entries (See #10 ). This e4ecd26 commit fixes that issue, as well.