Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly assumes CCD means credit #10

Closed
jdforsythe opened this issue Mar 29, 2016 · 4 comments
Closed

Incorrectly assumes CCD means credit #10

jdforsythe opened this issue Mar 29, 2016 · 4 comments

Comments

@jdforsythe
Copy link

This library incorrectly assumes that only CCD entries can be credits, and that all credits must be CCD entries.

Per the NACHA spec, CCD entries can be credit or debit entries, and other types of entries can be credit entries (e.g. PPD).

@philipwhitt
Copy link
Owner

Where specifically?

jdforsythe added a commit to jdforsythe/nacha-generator that referenced this issue Mar 29, 2016
…ss to contain debits and credits for all types. Fixes philipwhitt#10
@jdforsythe
Copy link
Author

Batch->addCreditEntry(CcdEntry $entry) in Batch.php

@jdforsythe
Copy link
Author

In reality the only difference between CCD and PPD or WEB is that it's a company name rather than an individual name (although we use PPD for non-profit orgs) - so in the PR #9 I just changed Entry to use "subject" rather than individual or company, and it eliminates the need for a separate classes altogether

@philipwhitt
Copy link
Owner

There is now a addEntry() method. addDebitEntry() and addCreditEntry() are effectively deprecated now, but still around to maintain the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants