Minor XS simplifications #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the docs, the perl_require_pv form is deprecated. Note I think the second of these calls is actually a bug since profile_class is a package name with colons, not a filename with slashes. We're not currently checking ERRSV after this call so it's probably silently failing. But such a fix is out of scope of this commit. Also it's probably worth moving to load_module instead as per the docs: It is analogous to the Perl code eval "require '$file'". It's even implemented that way; consider using load_module instead.
Also use an XPUSH macro to replace as explicit EXTEND.
Note hv_stores also drops the trailing hash param from its hv_store counterpart as the hash is computed automatically at compile time.
Tux
reviewed
Aug 20, 2024
There was a problem hiding this comment.
DBI is expected to run on 5.8.0, so for these kind of changes we should heavily depend on Devel::PPPort and its reports. DBI's version of ppport.h is dbipport. My own git checkout has a symlink from the last to the first. Problem with using it is that - due to that name choice - the tool keeps suggesting to add it.
The current Devel::PPPort suggests to remove the Perl_ prefixes completely, and I tend to agree, but as this has no functional or visible change (yet), I decided to postpone that work till after the 1.644 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of XS simplifications, see each commit for details.
Also I think I've found a bug, see the first commit for details.