Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor XS simplifications #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor XS simplifications #122

wants to merge 3 commits into from

Commits on Aug 20, 2024

  1. Remove "perl_" prefix from "perl_require_pv" 

    As per the docs, the perl_require_pv form is deprecated.

Note I think the second of these calls is actually a bug since
profile_class is a package name with colons, not a filename with
slashes. We're not currently checking ERRSV after this call so it's
probably silently failing. But such a fix is out of scope of this
commit.

Also it's probably worth moving to load_module instead as per the docs:

  It is analogous to the Perl code eval "require '$file'". It's even
  implemented that way; consider using load_module instead.
    @JRaspass
    JRaspass committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c9d3a3b View commit details
    Browse the repository at this point in the history

  2. Use mPUSH macros to replace sv_2mortal 

    Also use an XPUSH macro to replace as explicit EXTEND.
    @JRaspass
    JRaspass committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    43efca4 View commit details
    Browse the repository at this point in the history

  3. Use -s macros with literals to avoid magic numbers 

    Note hv_stores also drops the trailing hash param from its hv_store
counterpart as the hash is computed automatically at compile time.
    @JRaspass
    JRaspass committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c812819 View commit details
    Browse the repository at this point in the history