Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate pifaces #507

Merged
merged 13 commits into from
Jul 1, 2024
Merged

Consolidate pifaces #507

merged 13 commits into from
Jul 1, 2024

Conversation

donaldcampbelljr
Copy link
Contributor

Addresses #493

@donaldcampbelljr
Copy link
Contributor Author

This PR contains a lot of files because I needed to also pull in the refactored hello_looper-dev changes so that the tests would pass.Therefore, all of the changes under tests/data are simple refactoring

@donaldcampbelljr
Copy link
Contributor Author

Also, I believe we wanted to raise an exception if the pipeline_name is not the same as the one in the pipestat output schema when using pipestat. Currently, it only warns the user.

khoroshevskyi
khoroshevskyi approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks really good!

looper/project.py Outdated Show resolved Hide resolved
looper/utils.py Outdated Show resolved Hide resolved
@donaldcampbelljr donaldcampbelljr merged commit 923495d into dev_rename_args_455 Jul 1, 2024
1 check passed
@donaldcampbelljr donaldcampbelljr deleted the dev_consolidate_pifaces branch July 1, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoroshevskyi khoroshevskyi khoroshevskyi approved these changes

@nsheff nsheff Awaiting requested review from nsheff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldcampbelljr @khoroshevskyi