ibc: transparent address support

.changeset/wet-wombats-approve.md

@@ -0,0 +1,8 @@
+---
+'@penumbra-zone/protobuf': major
+'@penumbra-zone/services': minor
+'minifront': minor
+'@penumbra-zone/wasm': minor
+---
+
+support transparent addresses for usdc noble IBC withdrawals"

apps/minifront/src/state/ibc-in/index.tsx

@@ -21,7 +21,8 @@
 import { parseRevisionNumberFromChainId } from './parse-revision-number-from-chain-id';
 import { bech32ChainIds } from '../shared.ts';
 import { penumbra } from '../../penumbra.ts';
-import { TendermintProxyService } from '@penumbra-zone/protobuf';
+import { TendermintProxyService, ViewService } from '@penumbra-zone/protobuf';
+import { TransparentAddressRequest } from '@penumbra-zone/protobuf/penumbra/view/v1/view_pb';
 
 export interface IbcInSlice {
   selectedChain?: ChainInfo;
@@ -198,7 +199,7 @@
     throw new Error('Penumbra chain id could not be retrieved');
   }
 
-  const penumbraAddress = await getPenumbraAddress(account, selectedChain.chainId);
+  let penumbraAddress = await getPenumbraAddress(account, selectedChain.chainId);
   if (!penumbraAddress) {
     throw new Error('Penumbra address not available');
   }
@@ -207,11 +208,29 @@
   const assetMetadata = augmentToAsset(coin.raw.denom, selectedChain.chainName);
 
   const transferToken = fromDisplayAmount(assetMetadata, coin.displayDenom, amount);
+
+  const { address: t_addr, encoding: encoding } = await penumbra
+    .service(ViewService)
+    .transparentAddress(new TransparentAddressRequest({}));
+  if (!t_addr) {
+    throw new Error('Error with generating IBC transparent address');
+  }
+
+  // Temporary: detect USDC Noble inbound transfers, and use transparent (t-addr) encoding
+  // to ensure bech32m encoding compatibility.
+  if (
+    transferToken.denom.includes('uusdc') &&
+    (selectedChain.chainId == 'noble-1' || selectedChain.chainId == 'grand-1')
+  ) {
+    // Set the reciever address to the t-addr encoding.
+    penumbraAddress = encoding;
+  }
+
   const params: MsgTransfer = {
     sourcePort: 'transfer',
     sourceChannel: await getCounterpartyChannelId(selectedChain, penumbraChainId),
     sender,
-    receiver: penumbraAddress,
+    receiver: penumbraAddress!,
     token: transferToken,
     timeoutHeight,
     timeoutTimestamp,

apps/minifront/src/state/ibc-out.ts

@@ -2,6 +2,7 @@
 import {
   BalancesResponse,
   TransactionPlannerRequest,
+  TransparentAddressRequest,
 } from '@penumbra-zone/protobuf/penumbra/view/v1/view_pb';
 import { BigNumber } from 'bignumber.js';
 import { ClientState } from '@penumbra-zone/protobuf/ibc/lightclients/tendermint/v1/tendermint_pb';
@@ -24,14 +25,14 @@
 import { BLOCKS_PER_HOUR } from './constants';
 import { createZQuery, ZQueryState } from '@penumbra-zone/zquery';
 import { getChains } from '../fetchers/registry';
-import { bech32ChainIds } from './shared';
 import { penumbra } from '../penumbra';
 import {
   IbcChannelService,
   IbcClientService,
   IbcConnectionService,
   ViewService,
 } from '@penumbra-zone/protobuf';
+import { bech32ChainIds } from './shared';
 
 export const { chains, useChains } = createZQuery({
   name: 'chains',
@@ -206,7 +207,7 @@
   }
 
   const addressIndex = getAddressIndex(selection.accountAddress);
-  const { address: returnAddress } = await penumbra
+  let { address: returnAddress } = await penumbra
     .service(ViewService)
     .ephemeralAddress({ addressIndex });
   if (!returnAddress) {
@@ -215,20 +216,43 @@
 
   const { timeoutHeight, timeoutTime } = await getTimeout(chain.channelId);
 
+  // Request transparent address from view service
+  const { address: t_addr, encoding: _encoding } = await penumbra
+    .service(ViewService)
+    .transparentAddress(new TransparentAddressRequest({}));
+  if (!t_addr) {
+    throw new Error('Error with generating IBC transparent address');
+  }
+
+  // IBC-related fields
+  let denom = getMetadata(selection.balanceView).base;
+  let useTransparentAddress = false;
+
+  // Temporary: detect USDC Noble withdrawals, and use a transparent (t-addr) address
+  // to ensure bech32m encoding compatibility.
+  if (denom.includes('uusdc') && (chain.chainId == 'noble-1' || chain.chainId == 'grand-1')) {
+    // Use the t-addr for USDC withdrawals, and don't override existing
+    // 'useCompatAddress' field to maintain backwards compatibility.
+    useTransparentAddress = true;
+    // Set the return address to the t-addr.
+    returnAddress = t_addr;
+  }
+
   return new TransactionPlannerRequest({
     ics20Withdrawals: [
       {
         amount: toBaseUnit(
           BigNumber(amount),
           getDisplayDenomExponentFromValueView(selection.balanceView),
         ),
-        denom: { denom: getMetadata(selection.balanceView).base },
+        denom: { denom },
         destinationChainAddress,
         returnAddress,
         timeoutHeight,
         timeoutTime,
         sourceChannel: chain.channelId,
         useCompatAddress: bech32ChainIds.includes(chain.chainId),
+        useTransparentAddress,
       },
     ],
     source: addressIndex,

packages/protobuf/package.json

@@ -16,7 +16,7 @@
     "gen:ibc": "buf generate buf.build/cosmos/ibc:7ab44ae956a0488ea04e04511efa5f70",
     "gen:ics23": "buf generate buf.build/cosmos/ics23:55085f7c710a45f58fa09947208eb70b",
     "gen:noble": "buf generate buf.build/noble-assets/forwarding:5a8609a6772d417584a9c60cd8b80881",
-    "gen:penumbra": "buf generate buf.build/penumbra-zone/penumbra:37cef73133644d9dbdeae95b644db3ec",
+    "gen:penumbra": "buf generate buf.build/penumbra-zone/penumbra:0a56a4f32c244e7eb277e02f6e85afbd",
     "lint": "eslint src",
     "lint:fix": "eslint src --fix",
     "lint:strict": "tsc --noEmit && eslint src --max-warnings 0",

packages/services/src/view-service/index.ts

@@ -29,6 +29,7 @@ import { unclaimedSwaps } from './unclaimed-swaps.js';
 import { walletId } from './wallet-id.js';
 import { witness } from './witness.js';
 import { witnessAndBuild } from './witness-and-build.js';
+import { transparentAddress } from './transparent-address.js';
 
 export type Impl = ServiceImpl<typeof ViewService>;
 
@@ -62,4 +63,5 @@ export const viewImpl: Impl = {
   walletId,
   witness,
   witnessAndBuild,
+  transparentAddress,
 };

packages/services/src/view-service/transparent-address.ts

@@ -0,0 +1,13 @@
+import type { Impl } from './index.js';
+import { fvkCtx } from '../ctx/full-viewing-key.js';
+import { getTransparentAddress } from '@penumbra-zone/wasm/keys';
+
+export const transparentAddress: Impl['transparentAddress'] = async (_, ctx) => {
+  const fvk = await ctx.values.get(fvkCtx)();
+  const t_addr = getTransparentAddress(fvk);
+
+  return {
+    address: t_addr.address,
+    encoding: t_addr.encoding,
+  };
+};