Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: transparent address support #1950

Merged
merged 20 commits into from
Dec 22, 2024
Merged

ibc: transparent address support #1950

merged 20 commits into from
Dec 22, 2024

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Dec 18, 2024

remediates https://forum.penumbra.zone/t/usdc-transfers-temporarily-affected-by-noble-chain-upgrade/129 by detecting whether inbound / outbound IBC transfers involve Noble USDC and uses a transparent address (t-addr) to bypass the bech32 encoding compatibility issues that have previously blocked transfers. For all other assets sent to Noble, we use the penumbra1 encoding format.

references penumbra-zone/penumbra#4950

pairs with prax-wallet/prax#254

@TalDerei TalDerei self-assigned this Dec 18, 2024
Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 8712343

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@penumbra-zone/protobuf Major
@penumbra-zone/services Major
@penumbra-zone/bech32m Major
minifront Minor
@penumbra-zone/types Major
@penumbra-zone/wasm Major
node-status Patch
@penumbra-zone/client Major
@penumbra-zone/getters Major
@penumbra-zone/perspective Major
@penumbra-zone/storage Major
@penumbra-zone/ui-deprecated Major
@penumbra-zone/ui Patch
@penumbra-zone/crypto-web Major
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TalDerei TalDerei marked this pull request as draft December 18, 2024 18:45
@TalDerei TalDerei changed the title view service: transparent addresses ibc: transparent address support Dec 18, 2024
@TalDerei TalDerei marked this pull request as ready for review December 19, 2024 11:10
@TalDerei
Copy link
Contributor Author

TalDerei commented Dec 19, 2024

after the chain upgrade lands, I’d like to do some round-tripping testing around transparent addresses to complement the manual testing and provide greater assurance.


prax mainnet round-trip transactions

@TalDerei TalDerei requested review from hdevalence and a team December 19, 2024 11:39
@TalDerei TalDerei requested a review from erwanor December 20, 2024 21:41
// in the UI component library. For example, when handling IBC withdrawals with transparent
// addresses, this component transforms ephemeral addresses into their bech32-encoded
// transparent form to ensure the proper data is being displayed.
export const txvTranslator = async (view: TransactionView): Promise<TransactionView> => {
Copy link
Contributor Author

@TalDerei TalDerei Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renders the proper address format in the transaction view that's passed to the UI component library

Screenshot 2024-12-22 at 12 29 48 AM Screenshot 2024-12-22 at 12 29 39 AM

@TalDerei TalDerei merged commit 95d5fd9 into main Dec 22, 2024
6 checks passed
@TalDerei TalDerei deleted the t-addr branch December 22, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants