Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wasm): fix fee balancing bug for swap claims #1095

Merged
merged 17 commits into from
May 13, 2024
Merged

refactor(wasm): fix fee balancing bug for swap claims #1095

merged 17 commits into from
May 13, 2024

Conversation

TalDerei
Copy link
Contributor

References #876 and #1054

@TalDerei TalDerei marked this pull request as draft May 10, 2024 16:04
@TalDerei TalDerei self-assigned this May 10, 2024
@TalDerei TalDerei added the priority Important to work on next label May 10, 2024
@TalDerei TalDerei marked this pull request as ready for review May 10, 2024 20:41
grod220
grod220 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this fixed! 💪

Left comments, after you address, feel free to merge

packages/query/src/block-processor.ts Outdated Show resolved Hide resolved
packages/wasm/crate/src/planner.rs Show resolved Hide resolved
packages/wasm/crate/src/planner.rs Outdated Show resolved Hide resolved
packages/wasm/crate/src/planner.rs Outdated Show resolved Hide resolved
packages/wasm/crate/src/planner.rs Outdated Show resolved Hide resolved
packages/wasm/crate/src/planner.rs Outdated Show resolved Hide resolved
packages/wasm/crate/src/planner.rs Show resolved Hide resolved
@TalDerei TalDerei merged commit 02eae9b into main May 13, 2024
6 checks passed
@TalDerei TalDerei deleted the planner-fix branch May 13, 2024 20:46
@TalDerei TalDerei mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

@hdevalence hdevalence Awaiting requested review from hdevalence

@erwanor erwanor Awaiting requested review from erwanor

@jessepinho jessepinho Awaiting requested review from jessepinho

@turbocrime turbocrime Awaiting requested review from turbocrime

Assignees

@TalDerei TalDerei

Labels
priority Important to work on next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalDerei @grod220