Swap claims not being detected

[grod220]

Can validate this with the testnet whale given it currently has a number of unclaimed swaps.

Can successfully build, but will hang indefinitely as it waits for it to be detected on chain.

After refreshing after a bit, it does seem to be removed from the unclaimed swaps list, however it's not found in tx details page.

[erwanor]

@TalDerei might provide more color there but my understanding is that in penumbra-zone/penumbra#4312 we learned that the current wasm planner cannot balance SwapClaims, this was fixed in the PR, improved on in #4319, and needs to be backported/refactored via penumbra-zone/penumbra#4332

[erwanor]

Flagging this because I think the detection issue could be a surprising symptom of tx planning not working

[Valentine1898]

Could be related to #1003

After many attempts to debug #1003 I came up with nothing. It's like tendermint sometimes gives wrong transaction list for a block, but if you request transaction list for the same block after some time, everything is fine.

I'll try to provide more details, maybe it will be useful for this issue

[TalDerei]

currently looking into the issue. It seems to be the case that for different block heights, swap claims either (1) succeed, (2) fail due to binding signature verification failures, or (3) succeed but aren't populated in the transaction view.

[erwanor]

Could it be that depending on where they are emitted from, the prepaid fee is different, causing the balancing problem in some cases and not others? It might just be easier to push on making both impl use the same code and see if this goes away

[erwanor]

Hmm good point, it looks hardcoded to zero in minifront, and computed from the on-chain gas prices in pcli (which should be zero)

[TalDerei]

@erwanor if you look at this list, you'll notice some swaps are followed by a swap claim and others are not. The swaps that succeed and are followed by the swap claim have zero fees, while the swaps that succeed and are not followed by the swap claim have non-zero fees. It's a fee balancing bug, and we should push on penumbra-zone/penumbra#4332 and #876.

[erwanor]

Makes sense! nice sleuthing

[TalDerei]

tagging as on-hold until recent round of planner changes land in a slated 0.74.0 upgrade release, at which point we can update our rust deps and modify the web planner logic accordingly. Estimated timetable for release is Thursday.

cc @grod220 @conorsch

[TalDerei]

unblocked by https://github.com/penumbra-zone/penumbra/releases/tag/v0.74.0

[TalDerei]

closing -- fixed in #1095