Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automated generation of random txplans for effecthash testing #4879

Merged
merged 17 commits into from
Dec 2, 2024
Merged

automated generation of random txplans for effecthash testing #4879

merged 17 commits into from
Dec 2, 2024

Conversation

avahowell
Copy link
Contributor

@avahowell avahowell commented Oct 4, 2024 •
edited by redshiftzero
Loading

Closes #4613

@cronokirby cronokirby marked this pull request as draft October 7, 2024 20:53
@aubrika aubrika linked an issue Oct 21, 2024 that may be closed by this pull request
add EffectHash test vectors #4613
Closed
@redshiftzero redshiftzero changed the title wip: automated generation of random txplans for effecthash testing automated generation of random txplans for effecthash testing Oct 31, 2024
@redshiftzero redshiftzero marked this pull request as ready for review November 1, 2024 12:22
@redshiftzero
Copy link
Member

redshiftzero commented Nov 1, 2024 •
edited
Loading

This is ready for review: we now have the test utility generating all possible actions in a TransactionPlan, and to prevent regressions we compute the EffectHash computation based on those tx plans in a new test

@redshiftzero redshiftzero mentioned this pull request Dec 2, 2024
Open
@redshiftzero
Copy link
Member

Merging this and adding #4947 in a followup

@redshiftzero redshiftzero merged commit dcc8386 into main Dec 2, 2024
14 checks passed
@redshiftzero redshiftzero deleted the sig-test-vectors branch December 2, 2024 20:52
@redshiftzero redshiftzero mentioned this pull request Dec 2, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redshiftzero redshiftzero redshiftzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add EffectHash test vectors
2 participants
@avahowell @redshiftzero