Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add EffectHash test vectors #4613

Closed
redshiftzero opened this issue Jun 13, 2024 · 0 comments · Fixed by #4879
Closed

add EffectHash test vectors #4613

redshiftzero opened this issue Jun 13, 2024 · 0 comments · Fixed by #4879
Assignees
@redshiftzero @avahowell
Labels
A-testing Area: Relates to testing of Penumbra
Milestone
Sprint 15

Comments

@redshiftzero
Copy link
Member

We should add test vectors for the EffectHash mechanism for transaction signing, i.e. we should generate a bunch of random TransactionPlans, compute their EffectHash, and add them as test vectors. This will guard against additions of proto fields from breaking the effect hash as well as aid in development for others implementing transaction signing.
@redshiftzero redshiftzero added the A-testing Area: Relates to testing of Penumbra label Jun 13, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 13, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 13, 2024
@aubrika aubrika added this to the Sprint 10 milestone Aug 20, 2024
@aubrika aubrika removed the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 26, 2024
@aubrika aubrika modified the milestones: Sprint 10, Sprint 11 Aug 26, 2024
@aubrika aubrika modified the milestones: Sprint 11, Sprint 12 Sep 9, 2024
@aubrika aubrika modified the milestones: Sprint 12, Sprint 13 Sep 23, 2024
@avahowell avahowell mentioned this issue Oct 4, 2024
Merged
@aubrika aubrika modified the milestones: Sprint 13, Sprint 14 Oct 7, 2024
@aubrika aubrika modified the milestones: Sprint 14, Sprint 15 Oct 21, 2024
@aubrika aubrika linked a pull request Oct 21, 2024 that will close this issue
automated generation of random txplans for effecthash testing #4879
Merged
@redshiftzero redshiftzero mentioned this issue Dec 2, 2024
Open
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Dec 2, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

@avahowell avahowell

Labels
A-testing Area: Relates to testing of Penumbra
Projects
Penumbra
Archived in project
Milestone
Sprint 15
Development

Successfully merging a pull request may close this issue.

automated generation of random txplans for effecthash testing penumbra-zone/penumbra
3 participants
@redshiftzero @avahowell @aubrika