component: eliminate TOCTOU bug factory #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #3690 This renames the previous `check_stateful` method to `check_historical`, renames `execute` to `check_and_execute`, and by default moves all of the content of `check_stateful` into `check_and_execute`, unless there's an obvious and LOCAL reason why it's safe to do so that can be written into the body of the method. IMO it's still worth it to have the method in the trait. We may wish to take advantage of it later, when we can spend more time carefully reasoning about performance. Note: we've left behind two versions of the trait, which will be reconciled in a later commit.
Turns out we still need this trait; I commented why
hdevalence
commented
Mar 6, 2024
Comment on lines
36
to
39
| // These should be redundant given the choice to move these checks into check_and_execute | ||
| // but are left here for reference and as a defense in depth. | ||
| no_duplicate_spends(self)?; | ||
| no_duplicate_votes(self)?; |
There was a problem hiding this comment.
Slightly ambivalent on this point -- should we just delete?
There was a problem hiding this comment.
point in favor of deleting: people (me) might be tempted to add other such checks here
There was a problem hiding this comment.
sounds good, looks like our test suite is checking the exact error message, so we'll need to patch up the tests
There was a problem hiding this comment.
We probably don't want to just change the error message, but instead modify those tests to actually have the right FMD clues, to actually exercise duplicate nullifiers.
hdevalence
added
the
zellic-component-remediated
This temporarily disables a few relevant tests; these should be restored later.
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the previous
check_statefulmethod tocheck_historical,renames
executetocheck_and_execute, and by default moves all of thecontent of
check_statefulintocheck_and_execute, unless there's an obviousand LOCAL reason why it's safe to do so that can be written into the body of
the method.
IMO it's still worth it to have the method in the trait. We may wish to take
advantage of it later, when we can spend more time carefully reasoning about
performance.