Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable duplicate nullifier tests for spend and swap claims #3967

Open
cronokirby opened this issue Mar 7, 2024 · 0 comments
Open

Re-enable duplicate nullifier tests for spend and swap claims #3967

cronokirby opened this issue Mar 7, 2024 · 0 comments
Labels
A-testing Area: Relates to testing of Penumbra _P-medium Medium priority

Comments

@cronokirby
Copy link
Contributor

To merge #3962, we disabled these tests, because they were spuriously failing, because the order of checks we performed was different.

These tests expect a specific error message related to duplicate nullifiers, but were spuriously failing because of a message related to incorrect FMD clues.

We should re-enable these tests by fixing the spend preparation to use the right clues.

It might be good to wait until we have planner support in the test framework to upgrade these.

@cronokirby cronokirby added the A-testing Area: Relates to testing of Penumbra label Mar 7, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Mar 7, 2024
@aubrika aubrika added _P-V1 Priority: slated for V1 release _P-medium Medium priority labels Apr 24, 2024
@aubrika aubrika added this to the Sprint 8 milestone May 30, 2024
@aubrika aubrika removed the _P-V1 Priority: slated for V1 release label May 30, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra Jun 3, 2024
@aubrika aubrika removed this from the Sprint 8 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Area: Relates to testing of Penumbra _P-medium Medium priority
Projects
Status: Todo
Development

No branches or pull requests

2 participants