Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix about 20 typo #3919

Closed
wants to merge 4 commits into from
Closed

Fix about 20 typo #3919

wants to merge 4 commits into from

Conversation

miles-six
Copy link
Contributor

I have been studying this repository for a long time, and whenever I come across a typo, I fix it.

I discovered 20 typos in a total of 19 files. Then I merged them together.

The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

cratelyn
cratelyn approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very kind of you, @miles-six! thank you very much, this looks good to me. ✔️

@cratelyn cratelyn added the A-docs Area: Documentation needs for the project label Mar 1, 2024
@miles-six
Copy link
Contributor Author

Thank you! Waiting for you merge it.

cratelyn added a commit that referenced this pull request Mar 1, 2024
@cratelyn
proto: update typos
bae09e8 
this generates protobufs using typo fixes from #3919.
@cratelyn
Copy link
Contributor

cratelyn commented Mar 1, 2024

bae09e83d

i think you'll need to generate protobuf files in order to satisfy the ci checks. i pushed a commit here you can cherry-pick into your branch. that should fix things!

@miles-six
Copy link
Contributor Author

miles-six commented Mar 2, 2024 •
edited
Loading

@cratelyn hey, I have a question:
I'm not very familiar with GitHub commands, so I made some modifications based on your previous commit not cherry-pick. However, things seem to have gotten worse.

Do I need to submit a new PR to submit this typo fixes? and run ./deployments/scripts/protobuf-codegen locally after fix them,then I commit?

Sorry about that.

@miles-six
Copy link
Contributor Author

miles-six commented Mar 4, 2024 •
edited
Loading

@cratelyn Hey,I want to know that only satisfy the ci checks can be merged?

@cratelyn
Copy link
Contributor

cratelyn commented Mar 4, 2024

@cratelyn Hey,I want to know that only satisfy the ci checks can be merged?

yes, pr's need to satisfy all ci checks to be merged.

@miles-six miles-six closed this by deleting the head repository Mar 5, 2024
This was referenced Mar 5, 2024
Closed
Merged
cratelyn pushed a commit that referenced this pull request Mar 5, 2024
@miles-six
chore: fix typos in assorted comments (#3947)
f3ef215 
@cratelyn  I re-pull request #3919 and finally passed all the checks
thanks for your help!
@grod220 Waiting for you guys merge it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

Assignees
No one assigned
Labels
A-docs Area: Documentation needs for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-six @cratelyn