Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #3947

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix issue #3947

merged 1 commit into from
Mar 5, 2024

Conversation

miles-six
Copy link
Contributor

@miles-six miles-six commented Mar 5, 2024 •
edited
Loading

@cratelyn I re-pull request #3919 and finally passed all the checks
thanks for your help!
@grod220 Waiting for you guys merge it!

cratelyn
cratelyn approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! thank you very much 🙂

@cratelyn cratelyn merged commit f3ef215 into penumbra-zone:main Mar 5, 2024
6 checks passed
@cratelyn cratelyn added A-docs Area: Documentation needs for the project C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

Assignees
No one assigned
Labels
A-docs Area: Documentation needs for the project C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-six @cratelyn