tests: ✨ provide app state in genesis request #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
commented
Feb 13, 2024
hdevalence
requested changes
Feb 13, 2024
cratelyn
added a commit
that referenced
this pull request
Feb 13, 2024
rephrase the builder interfaces in terms of application-agnostic types. addresses the pr review linked below. NB: because `InitChain::app_state_bytes` is a `Bytes`, see https://rustdoc.penumbra.zone/main/tendermint/abci/request/struct.InitChain.html#structfield.app_state_bytes ...i've written `Builder::app_state` to accept an `Into<Bytes>`. this allows callers to provide some other common types, like... - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3C%26'static+%5Bu8%5D%3E-for-Bytes - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3C%26'static+str%3E-for-Bytes - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3CBox%3C%5Bu8%5D,+Global%3E%3E-for-Bytes - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3CString%3E-for-Bytes > This should be taking a Vec, so that the mock engine code doesn't > build in Penumbra dependencies. Instead, we'll want to have a > penumbra_app_state method in an extension trait like we sketched while > pairing that does the serialization and calls this method with the > resulting bytes. #3810 (review) referenced code: https://github.com/penumbra-zone/penumbra/pull/3597/files#diff-4b1c924f57b5a531a0be51a9975a35280b53ba9c3f8019a01839859a171aa9a1R10 Co-Authored-By: Henry de Valence <[email protected]>
rephrase the builder interfaces in terms of application-agnostic types. addresses the pr review linked below. NB: because `InitChain::app_state_bytes` is a `Bytes`, see https://rustdoc.penumbra.zone/main/tendermint/abci/request/struct.InitChain.html#structfield.app_state_bytes ...i've written `Builder::app_state` to accept an `Into<Bytes>`. this allows callers to provide some other common types, like... - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3C%26'static+%5Bu8%5D%3E-for-Bytes - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3C%26'static+str%3E-for-Bytes - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3CBox%3C%5Bu8%5D,+Global%3E%3E-for-Bytes - https://docs.rs/bytes/latest/bytes/struct.Bytes.html#impl-From%3CString%3E-for-Bytes > This should be taking a Vec, so that the mock engine code doesn't > build in Penumbra dependencies. Instead, we'll want to have a > penumbra_app_state method in an extension trait like we sketched while > pairing that does the serialization and calls this method with the > resulting bytes. #3810 (review) referenced code: https://github.com/penumbra-zone/penumbra/pull/3597/files#diff-4b1c924f57b5a531a0be51a9975a35280b53ba9c3f8019a01839859a171aa9a1R10 Co-Authored-By: Henry de Valence <[email protected]>
cratelyn
force-pushed
the
katie/send-init-chain-contd
branch
from
17cfd12 to
0c201c8
Compare
hdevalence
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow-on to #3807. this makes the
mock_consensus_can_send_an_init_chain_requesttest pass.see #3588.
add an app state field to the builder, thread that through to the abci request. log this after the response is received.