Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: 🎪 App can be instantiated with mock consensus #3787

Closed
cratelyn opened this issue Feb 8, 2024 · 1 comment
Closed

tests: 🎪 App can be instantiated with mock consensus #3787

cratelyn opened this issue Feb 8, 2024 · 1 comment
Assignees
@cratelyn
Labels
A-mock-consensus Area: Relates to the mock consensus engine C-enhancement Category: an enhancement to the codebase _P-high High priority

Comments

@cratelyn
Copy link
Contributor

cratelyn commented Feb 8, 2024

see #3588.

#3781 added some test stubs for our mock engine that compile, but do not yet pass. now, write the basic functionality needed to instantiate the App in a test with the mock consensus engine.
@cratelyn cratelyn added C-enhancement Category: an enhancement to the codebase A-mock-consensus Area: Relates to the mock consensus engine labels Feb 8, 2024
@cratelyn cratelyn self-assigned this Feb 8, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Feb 8, 2024
@github-project-automation github-project-automation bot moved this to Future in Testnets Feb 8, 2024
This was referenced Feb 8, 2024
Closed
Closed
Merged
@hdevalence hdevalence added the _P-high High priority label Feb 9, 2024
This was referenced Feb 9, 2024
Merged
Closed
Closed
@cratelyn cratelyn moved this from 🗄️ Backlog to Done in Penumbra Feb 13, 2024
@cratelyn
Copy link
Contributor Author

cratelyn commented Feb 14, 2024 •
edited
Loading

this was marked complete, and fixed by #3807 and #3810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cratelyn cratelyn

Labels
A-mock-consensus Area: Relates to the mock consensus engine C-enhancement Category: an enhancement to the codebase _P-high High priority
Projects
Penumbra
Archived in project
Testnets
Status: Future
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hdevalence @cratelyn