Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Reorder css classes - Round 3 (larva-patterns/modules/c*) #811

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Cleanup: Reorder css classes - Round 3 (larva-patterns/modules/c*) #811

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a53dae1
Reorder css classes for modules that start with 'c'
nayeonk Aug 8, 2023
32067ff
Merge with master
nayeonk Aug 22, 2023
ad85dd8
npm run prod build
nayeonk Aug 22, 2023
391fd36
Merge branch 'master' into feature/reorder-css-classes-3
nayeonk Aug 22, 2023
a8442f4
Run npm run prod
nayeonk Aug 22, 2023
9c4cdbb
Rebuild
nayeonk Aug 22, 2023
8ca1230
Update changelog
nayeonk Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/css/larva-important.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/css/larva.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/css/larva.inline-important.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/css/larva.inline.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/svg/defs/sprite.defs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ <h2>youtube</h2>

</section>
<footer>
<p>Generated at Tue, 22 Aug 2023 18:05:10 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
<p>Generated at Tue, 22 Aug 2023 18:47:24 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
</footer>
</body>
</html>
2 changes: 1 addition & 1 deletion packages/larva-css/build/css/algorithms.common.async.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions packages/larva-css/build/css/algorithms.common.inline.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/larva-patterns/modules/container/container.prototype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
container_markup: 'hello markup',
container_classes: 'lrv-a-font-body-m lrv-u-margin-lr-auto',
container_classes: 'lrv-u-margin-lr-auto lrv-a-font-body-m',
container_background_color_class: '',
container_color_class: '',
container_text_align_class: '',
Expand Down
6 changes: 3 additions & 3 deletions packages/larva-patterns/modules/content-showcase/content-showcase.prototype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ o_card.o_card_link_url = '#';
o_card.o_card_image_wrap_classes =
'lrv-u-flex-basis-40p@desktop lrv-u-flex-basis-40p@desktop-xl lrv-u-flex-basis-25p@mobile-max';
o_card.o_card_content_classes =
'lrv-u-margin-l-1 lrv-u-color-brand-primary:hover lrv-u-flex-basis-60p@desktop lrv-u-flex-basis-60p@desktop-xl lrv-u-flex-basis-55p@mobile-max';
'lrv-u-margin-l-1 lrv-u-flex-basis-60p@desktop lrv-u-flex-basis-60p@desktop-xl lrv-u-flex-basis-55p@mobile-max lrv-u-color-brand-primary:hover';

o_card.c_lazy_image.c_lazy_image_link_url = '';
o_card.c_lazy_image.c_lazy_image_classes =
Expand All @@ -28,13 +28,13 @@ o_card.c_span = false;
o_card.c_title.c_title_url = '';
o_card.c_title.c_title_text =
'Perfection is rarely achieved in movies, but this heaven-sent concert doc hits the sweet spot.';
o_card.c_title.c_title_classes = 'lrv-u-font-weight-normal lrv-u-margin-tb-1';
o_card.c_title.c_title_classes = 'lrv-u-margin-tb-1 lrv-u-font-weight-normal';
o_card.c_timestamp = false;
o_card.c_tagline = false;
o_card.o_author = false;

module.exports = {
content_showcase_items_classes:
'lrv-u-flex lrv-u-flex-direction-column@mobile-max lrv-u-padding-tb-1@desktop lrv-u-width-100p lrv-u-padding-lr-125@mobile-max',
'lrv-u-flex lrv-u-flex-direction-column@mobile-max lrv-u-padding-tb-1@desktop lrv-u-padding-lr-125@mobile-max lrv-u-width-100p',
content_showcase_items: [ o_card, o_card, o_card ],
};
10 changes: 5 additions & 5 deletions packages/larva-patterns/modules/content-showcase/content-showcase.the-moth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,29 +13,29 @@ o_card.c_tagline = false;
o_card.o_author = false;

o_card.o_card_classes =
'lrv-u-display-inline-flex lrv-u-flex-basis-100p@desktop-xl lrv-u-flex-basis-100p@desktop lrv-u-padding-tb-00@mobile-max lrv-u-flex-shrink-0@mobile-max';
'lrv-u-display-inline-flex lrv-u-flex-shrink-0@mobile-max lrv-u-flex-basis-100p@desktop-xl lrv-u-flex-basis-100p@desktop lrv-u-padding-tb-00@mobile-max';
o_card.o_card_link_classes = 'lrv-u-flex';
o_card.o_card_link_url = '#';
o_card.o_card_image_wrap_classes =
'lrv-u-flex-basis-40p@desktop lrv-u-flex-basis-40p@desktop-xl lrv-u-flex-basis-25p@mobile-max';
o_card.c_lazy_image.c_lazy_image_classes = 'lrv-u-width-100';
o_card.o_card_content_classes =
'lrv-u-margin-l-1 lrv-u-color-brand-primary:hover lrv-u-flex-basis-60p@desktop lrv-u-flex-basis-60p@desktop-xl lrv-u-flex-basis-55p@mobile-max lrv-u-color-black';
'lrv-u-flex-basis-60p@desktop lrv-u-flex-basis-60p@desktop-xl lrv-u-flex-basis-55p@mobile-max lrv-u-margin-l-1 lrv-u-color-black lrv-u-color-brand-primary:hover';
o_card.c_title.c_title_text = 'Canceling Noodle The Pug';
o_card.c_title.c_title_classes =
'lrv-a-font-body-l lrv-u-text-decoration-underline:hover lrv-u-margin-b-00 lrv-u-margin-t-050 lrv-u-line-height-copy';
'lrv-u-margin-t-050 lrv-u-margin-b-00 lrv-a-font-body-l lrv-u-text-decoration-underline:hover lrv-u-line-height-copy';
o_card.c_title.c_title_link_classes =
'lrv-u-color-black lrv-u-color-brand-secondary-dark:hover';
o_card.c_lazy_image.c_lazy_image_crop_class = 'lrv-a-crop-1x1';
o_card.article_kicker = article_kicker;
o_card.article_kicker.article_kicker_classes =
'lrv-u-color-black lrv-u-color-brand-secondary-dark:hover lrv-u-text-transform-uppercase lrv-a-font-basic-s lrv-u-position-relative lrv-u-padding-b-050';
'lrv-u-position-relative lrv-u-padding-b-050 lrv-u-color-black lrv-u-color-brand-secondary-dark:hover lrv-u-text-transform-uppercase lrv-a-font-basic-s';
o_card.article_kicker.article_kicker_link_classes = 'lrv-u-color-black';

content_showcase.content_showcase_classes =
'the-moth lrv-u-border-t-1 lrv-u-font-family-body lrv-a-glue-parent';
content_showcase.content_showcase_items_classes =
'the-moth-items lrv-u-overflow-auto@mobile-max lrv-u-padding-r-2@mobile-max lrv-u-flex-shrink-0@mobile-max lrv-u-border-b-1 lrv-u-border-t-1 lrv-u-flex lrv-u-margin-t-025 lrv-u-padding-lr-125@mobile-max lrv-u-padding-tb-150 lrv-u-width-100p';
'the-moth-items lrv-u-overflow-auto@mobile-max lrv-u-flex-shrink-0@mobile-max lrv-u-flex lrv-u-margin-t-025 lrv-u-border-b-1 lrv-u-border-t-1 lrv-u-padding-tb-150 lrv-u-padding-r-2@mobile-max lrv-u-padding-lr-125@mobile-max lrv-u-width-100p';

content_showcase.content_showcase_items = [ o_card, o_card, o_card, o_card ];

Expand Down
2 changes: 1 addition & 1 deletion packages/larva/build/css/larva-important.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/larva/build/css/larva.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/larva/build/css/larva.inline-important.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/larva/build/css/larva.inline.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/larva/build/svg/defs/sprite.defs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ <h2>youtube</h2>

</section>
<footer>
<p>Generated at Tue, 22 Aug 2023 18:05:10 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
<p>Generated at Tue, 22 Aug 2023 18:47:24 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
</footer>
</body>
</html>
Loading