Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Reorder css classes - Round 3 (larva-patterns/modules/c*) #811

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

nayeonk
Copy link
Contributor

@nayeonk nayeonk commented Aug 8, 2023

Cleanup round 3 of many to reorder css classes based on WP standards: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#property-ordering

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pmc-larva ❌ Failed (Inspect) Aug 22, 2023 8:36pm

JordanPak
JordanPak previously approved these changes Aug 22, 2023
JordanPak
JordanPak previously approved these changes Aug 22, 2023
@github-actions
Copy link
Contributor

🚨 Backstop Visual Regression Tests Failed: View the results for a8442f44a55384e416c0df1907c8571610a1f05f.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

1 similar comment
@github-actions
Copy link
Contributor

🚨 Backstop Visual Regression Tests Failed: View the results for a8442f44a55384e416c0df1907c8571610a1f05f.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

@nayeonk nayeonk merged commit 25f7d5f into master Sep 19, 2023
3 checks passed
@nayeonk nayeonk deleted the feature/reorder-css-classes-3 branch September 19, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants