Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6505 #6887

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6505 into stable2409 from seadanda.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6505-to-stable2409
git worktree add --checkout .worktree/backport-6505-to-stable2409 backport-6505-to-stable2409
cd .worktree/backport-6505-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 459b4a6521d35f3e84a036262e64fa547a5b1ff4
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 13, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7917685

Fix the broker pallet auto-renew benchmarks which have been broken since
reported in #6474.

Upon further investigation it turned out that the auto-renew
contribution to `rotate_sale` was always failing but the error was
mapped. This is also fixed at the cost of a bit of setup overhead.

Fixes #6474

TODO:
- [x] Re-run weights

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 459b4a6)
@seadanda seadanda force-pushed the backport-6505-to-stable2409 branch from 4f69de8 to 44be100 Compare December 13, 2024 17:15
@seadanda
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 13, 2024

@seadanda https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7918116 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-c3e232e9-fc07-410a-9f04-5f218c67a3d7 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 13, 2024

@seadanda Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7918116 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7918116/artifacts/download.

@seadanda seadanda marked this pull request as ready for review December 13, 2024 17:29
@seadanda seadanda requested a review from a team as a code owner December 13, 2024 17:29
@EgorPopelyaev EgorPopelyaev merged commit 776e8de into stable2409 Dec 17, 2024
148 of 184 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6505-to-stable2409 branch December 17, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants