[pallet-broker] Fix auto renew benchmarks #6505
Conversation
seadanda
added
T2-pallets
|
/cmd prdoc --audience runtime_dev --bump minor |
| let region = Broker::<T>::do_purchase(caller.clone(), 10u32.into()) | ||
| .map_err(|_| BenchmarkError::Weightless)?; | ||
| let region = Broker::<T>::do_purchase(caller.clone(), 10_000_000u32.into()) | ||
| .expect("Offer not high enough for configuration."); |
There was a problem hiding this comment.
Since we advance to the fixed price phase, this is independent of the price adapter implementation and depends only on the config value set earlier in this file. Therefore it's better to unwrap here so the test fails, rather than always being mapped to Weightless.
|
bot bench substrate-pallet --pallet=pallet_broker |
|
bot bench cumulus-coretime --runtime=coretime-westend --pallet=pallet_broker |
|
bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_broker |
|
bot bench cumulus-coretime --features=runtime-benchmarks --runtime=coretime-westend --pallet=pallet_broker |
|
This will affect polkadot-fellows/runtimes#490 Until this PR is merged and backported we should filter these calls and set MaxAutoRenewals to 0 |
…=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_broker
This reverts commit 3239d4b.
|
bot bench cumulus-coretime --features=runtime-benchmarks --runtime=coretime-westend --pallet=pallet_broker |
…=coretime-westend --runtime_dir=coretime --target_dir=cumulus --features=runtime-benchmarks --pallet=pallet_broker
…=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --features=runtime-benchmarks --pallet=pallet_broker
|
bot clean |
|
@seadanda Command |
…=coretime-westend --runtime_dir=coretime --target_dir=cumulus --features=runtime-benchmarks --pallet=pallet_broker
…=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --features=runtime-benchmarks --pallet=pallet_broker
|
@seadanda Command |
|
@seadanda Command |
seadanda
added
the
A4-needs-backport
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6505-to-stable2407
git worktree add --checkout .worktree/backport-6505-to-stable2407 backport-6505-to-stable2407
cd .worktree/backport-6505-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 459b4a6521d35f3e84a036262e64fa547a5b1ff4
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6505-to-stable2409
git worktree add --checkout .worktree/backport-6505-to-stable2409 backport-6505-to-stable2409
cd .worktree/backport-6505-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 459b4a6521d35f3e84a036262e64fa547a5b1ff4
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6505-to-stable2412
git worktree add --checkout .worktree/backport-6505-to-stable2412 backport-6505-to-stable2412
cd .worktree/backport-6505-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 459b4a6521d35f3e84a036262e64fa547a5b1ff4
git push --force-with-lease |
Fix the broker pallet auto-renew benchmarks which have been broken since reported in #6474. Upon further investigation it turned out that the auto-renew contribution to `rotate_sale` was always failing but the error was mapped. This is also fixed at the cost of a bit of setup overhead. Fixes #6474 TODO: - [x] Re-run weights --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <[email protected]> (cherry picked from commit 459b4a6)
seadanda
had a problem deploying
to
subsystem-benchmarks
GitHub Actions
Failure
Fix the broker pallet auto-renew benchmarks which have been broken since reported in #6474. Upon further investigation it turned out that the auto-renew contribution to `rotate_sale` was always failing but the error was mapped. This is also fixed at the cost of a bit of setup overhead. Fixes #6474 TODO: - [x] Re-run weights --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <[email protected]> (cherry picked from commit 459b4a6)
Backport #6505 into `stable2412` from seadanda. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Dónal Murray <[email protected]>
Backport #6505 into `stable2409` from seadanda. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: command-bot <>
Fix the broker pallet auto-renew benchmarks which have been broken since #4424, yielding
Weightlessdue to some prices being set too low, as reported in #6474.Upon further investigation it turned out that the auto-renew contribution to
rotate_salewas always failing but the error was mapped. This is also fixed at the cost of a bit of setup overhead.Fixes #6474
TODO: