[stable2407] Backport #6031 #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![paritytech-cmd-bot-polkadot-sdk[bot]](https://avatars.githubusercontent.com/in/975620?s=60&v=4){kind=small}
# Description
I'm unable to build a bridge library due to the errors below, so I am
adding the explicit import to `sp_std::vec`.
## Integration
Projects using it can update their dependency. We are using the branch
`stable2407` (mixed them up in my branch).
## Errors
```
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19
|
99 | let mut route = vec![];
| ^^^
|
help: consider importing one of these items
|
23 + use scale_info::prelude::vec;
|
23 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36
|
135 | duplicate_votes_ancestries_idxs: vec![],
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21
|
134 | extra_precommits: vec![],
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27
|
89 | let mut equivocations = vec![];
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
```
---------
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Serban Iorga <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
(cherry picked from commit 31dfc9f)
github-actions
bot
added
the
A3-backport
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6031 into
stable2407from drewstone.See the documentation on how to use this bot.