Import vec to bridges/primitives/header-chain #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
changed the title
bkchr
previously approved these changes
Oct 15, 2024
|
@drewstone please provide a prdoc. |
serban300
previously approved these changes
Oct 15, 2024
|
/cmd prdoc --audience node_dev --bump patch |
|
Command "prdoc --audience node_dev --bump patch" has failed ❌! See logs here |
|
@bkchr can you confirm I added the prdoc correctly? |
bkchr
previously approved these changes
Oct 15, 2024
bridges/primitives/header-chain/src/justification/verification/mod.rs
Outdated
Show resolved
Hide resolved
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
@drewstone can you merge master? |
bkchr
force-pushed
the
drew/stable2047
branch
from
7c0381b to
8896b95
Compare
bkchr
requested review from
athei,
acatangiu,
sorpaas,
cheme,
a team and
koute
as code owners
bkchr
approved these changes
Oct 16, 2024
bkchr
added
the
A4-needs-backport
bkontur
approved these changes
Oct 16, 2024
serban300
approved these changes
Oct 16, 2024
|
Ah darn I had opened this against stable2407 cause we are pegged to that lol. We needed it in that branch foremost. |
That's fine, it will be backported to that branch once we merge it to master. |
|
bot fmt |
|
@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7592101 was started for your command Comment |
|
@acatangiu Command |
Merged
via the queue into
paritytech:master
with commit Oct 17, 2024
31dfc9f
190 of 193 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
# Description
I'm unable to build a bridge library due to the errors below, so I am
adding the explicit import to `sp_std::vec`.
## Integration
Projects using it can update their dependency. We are using the branch
`stable2407` (mixed them up in my branch).
## Errors
```
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19
|
99 | let mut route = vec![];
| ^^^
|
help: consider importing one of these items
|
23 + use scale_info::prelude::vec;
|
23 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36
|
135 | duplicate_votes_ancestries_idxs: vec![],
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21
|
134 | extra_precommits: vec![],
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27
|
89 | let mut equivocations = vec![];
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
```
---------
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Serban Iorga <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
(cherry picked from commit 31dfc9f)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
# Description
I'm unable to build a bridge library due to the errors below, so I am
adding the explicit import to `sp_std::vec`.
## Integration
Projects using it can update their dependency. We are using the branch
`stable2407` (mixed them up in my branch).
## Errors
```
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19
|
99 | let mut route = vec![];
| ^^^
|
help: consider importing one of these items
|
23 + use scale_info::prelude::vec;
|
23 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36
|
135 | duplicate_votes_ancestries_idxs: vec![],
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:134:21
|
134 | extra_precommits: vec![],
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
|
error: cannot find macro `vec` in this scope
--> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c3250/bridges/primitives/header-chain/src/justification/verification/equivocation.rs:89:27
|
89 | let mut equivocations = vec![];
| ^^^
|
help: consider importing one of these items
|
19 + use scale_info::prelude::vec;
|
19 + use sp_std::vec;
```
---------
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Serban Iorga <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
(cherry picked from commit 31dfc9f)
|
Successfully created backport PR for |
bkchr
pushed a commit
that referenced
this pull request
Oct 18, 2024
Backport #6031 into `stable2409` from drewstone. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: drewstone <[email protected]>
EgorPopelyaev
added a commit
that referenced
this pull request
Dec 4, 2024
Backport #6031 into `stable2407` from drewstone. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: drewstone <[email protected]> Co-authored-by: Egor_P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm unable to build a bridge library due to the errors below, so I am adding the explicit import to
sp_std::vec.Integration
Projects using it can update their dependency. We are using the branch
stable2407(mixed them up in my branch).Errors