added check to ensure there are approvals #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an api check to verify that there are pre-existing approvals in the PR before dismissing reviews
Bullrich
added
the
R0-silent
alvicsam
approved these changes
Apr 16, 2024
|
Review required! Latest push from author must always be reviewed |
AndWeHaveAPlan
approved these changes
Apr 16, 2024
EgorPopelyaev
approved these changes
Apr 16, 2024
Bullrich
added a commit
to Bullrich/polkadot-fellows-runtimes
that referenced
this pull request
Apr 16, 2024
1 task
Bullrich
added a commit
to Bullrich/polkadot-fellows-runtimes
that referenced
this pull request
Apr 16, 2024
|
Thank you @Bullrich |
Bullrich
added a commit
to Bullrich/polkadot-fellows-runtimes
that referenced
this pull request
May 7, 2024
fellowship-merge-bot bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
May 7, 2024
Added a script that will require new reviews in a PR if the author (who is not a fellow) pushed a new commit. Resolves #60 Copied from paritytech/polkadot-sdk#4152 and paritytech/polkadot-sdk#3431 ## Summary Added a new step in the action that triggers review bot to stop approval from new pushes. This step works in the following way: - If the **author of the PR**, who **is not** a fellow, pushed a new commit then: - Review-Trigger requests new reviews from the reviewers and fails. It *does not dismiss reviews*. It simply request them again, but they will still be available. This way, if the author changed something in the code, they will still need to have this latest change approved to stop them from uploading malicious code. - [x] Does not require a CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3431
Added an api check to verify that there are pre-existing approvals in the PR before dismissing reviews and posting a message