fix(op): fix payload id calculation #11730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
|
EDIT: the test now fails because we need to put the version as the first byte, which is sort of annoying: from op-geth: out[0] = byte(args.Version)
return out |
mattsse
approved these changes
Oct 15, 2024
Comment on lines
292
to
294
| let no_tx_pool = attributes.no_tx_pool.unwrap_or_default(); | ||
| hasher.update([no_tx_pool as u8]); | ||
| let txs_len = attributes.transactions.as_ref().map(|txs| txs.len()).unwrap_or_default(); |
There was a problem hiding this comment.
we now have multiple calls to unwrap_or_default.
can we do this just once
|
any updates to this? seems like geth adds the payload version to the payload_id that is causing the discrepancy |
mattsse
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #11729
Also updates to add the newly added eip1559 params
Right now the test from the issue fails, hopefully something simple