Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osiris/reth compatibility #18

Closed
wants to merge 4 commits into from

Conversation

0xOsiris
Copy link

Overview

  • This PR removes the assumption that the build process id of the builder matches the build process id of the l2 client.

When testing with a reth builder the process id's didn't match which downstream caused issues in get_payload_v3 when trying to grab the payload from the builder.

Solution

  • Ephemerally map the build process id of the l2 client to the build process id of the builder in fork_choice_update_v3 when a build process has been started.
  • The downside here is we now need to wait for both futures to resolve in fork_choice_update_v3

Note: This has been load tested with both a Reth builder, and a op-geth builder in a rollup devnet.

@0xOsiris
Copy link
Author

Closing as this is being addressed: paradigmxyz/reth#11730

@0xOsiris 0xOsiris closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant