Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document duplicated CODECOV_TOKEN in GitHub settings #365

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@ on:
push:
branches:
- main

# Though GitHub's documentation mostly says you only need this for reusable
# workflows (i.e. workflows that call other workflows), it seems that GitHub
# does not pass secrets to `pull_request` events that come from forks (which
# it seems Dependabot's PRs do?) unless they are explicitly passed through,
# because they do not want a forker's PR to be able to exfiltrate secret data
# from the forked repo. This behavior is not really documented with respect to
# Dependabot but some hints are here:
# - https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow
# - https://github.com/pypa/gh-action-pypi-publish/discussions/49
workflow_call:
secrets:
CODECOV_TOKEN:
required: true
jobs:
ci:
name: CI
Expand Down Expand Up @@ -57,6 +43,9 @@ jobs:
with:
files: ./coverage/coverage.xml
fail_ci_if_error: true # optional (default = false)
# NOTE: If you change this secret, you must change it under the repo
# secrets settings for both GitHub Actions *and* Dependabot secrets. For
# more context, see: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#responding-to-events
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true # optional (default = false)
if: matrix.ruby == 3.3
Expand Down
Loading