Document duplicated CODECOV_TOKEN in GitHub settings
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobEvelyn
force-pushed
the
secret-push
branch
from
8d0d47a to
acae1ae
Compare
This commit adds documentation to the fix needed to ensure that Codecov works for PRs that are both created by engineers and created by Dependabot.
JacobEvelyn
force-pushed
the
secret-push
branch
from
acae1ae to
2716b1d
Compare
murshed-panorama
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 190 190
Branches 90 90
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds documentation to the fix needed to ensure that Codecov works for PRs that are both created by engineers and created by Dependabot.
I tested this by recreating this Dependabot PR after setting the secret in the repo settings and confirming that the Codecov CI step passed when previously it failed.
Before merging:
Copy the table printed at the end of the latest benchmark results into theREADME.mdand update this PRIf this change merits an update toCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning