Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: filter possible RuntimeWarning in tests #60553

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

mroeschke
Copy link
Member

I'm unsure why the OSX 13, Python 3.10 & 3.11 jobs are just complaining about an invalid value in cast from .astype of a ndarray of exotic types like interval to str (and then object), but I think generally we should be safe to ignore this.

e.g. https://github.com/pandas-dev/pandas/actions/runs/12286515835/job/34286806506

@mroeschke mroeschke added the Warnings Warnings that appear or should be added to pandas label Dec 12, 2024
@mroeschke mroeschke added this to the 2.3 milestone Dec 12, 2024
@mroeschke mroeschke changed the title Ignore possible RuntimeWarning in _hash_ndarray TST: filtern possible RuntimeWarning in tests Dec 12, 2024
@mroeschke mroeschke changed the title TST: filtern possible RuntimeWarning in tests TST: filter possible RuntimeWarning in tests Dec 12, 2024
@mroeschke
Copy link
Member Author

Going to merge to get the CI closer to green

@mroeschke mroeschke merged commit c52846f into pandas-dev:main Dec 13, 2024
50 of 51 checks passed
Copy link

lumberbot-app bot commented Dec 13, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c52846ff94d51ce5940928c199da00f403bc8138
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60553: TST: filter possible RuntimeWarning in tests'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60553-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60553 on branch 2.3.x (TST: filter possible RuntimeWarning in tests)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke mroeschke deleted the fix/warning/hashing branch December 13, 2024 02:02
mroeschke added a commit to mroeschke/pandas that referenced this pull request Dec 13, 2024
mroeschke added a commit that referenced this pull request Dec 13, 2024
)

* Backport PR #60553: TST: filter possible RuntimeWarning in tests

* add more ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant