Fix the metadata propagation in Dataframe.std #52924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiawei-zhang-a
changed the title
|
Looks like there's typing issue which indicates this needs fixed at a lower level |
|
Yeah it seems so, i will figure it out |
|
Fix the typing problem by forcing the only propagation on Series |
MarcoGorelli
requested changes
Apr 28, 2023
pandas/core/frame.py
Outdated
Comment on lines
11075
to
11076
| else: | ||
| return result |
There was a problem hiding this comment.
this should be unreachable, and looks like a case where we humans looking at the code can infer things which the type checker can't
I'd suggest
result = cast(Series, super().std(...)
return result.__finalize_(...)
There was a problem hiding this comment.
Thank you so much, Mr Gorelli! I appreciate your help so much, I will submit this:)
|
changes look good, if you add a whatsnew note to 2.1.0.rst we can get this in |
|
Sure! I will add it now, Sorry I forget to add |
mroeschke
approved these changes
May 1, 2023
|
Thanks @jiawei-zhang-a |
NumanIjaz
pushed a commit
to NumanIjaz/pandas
that referenced
this pull request
May 1, 2023
* Fix the metadata propagation both in Dataframe.std * Fix the typing problem by forcing propogation only on Series * From judge statement to cast * Add whatsnew
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
* Fix the metadata propagation both in Dataframe.std * Fix the typing problem by forcing propogation only on Series * From judge statement to cast * Add whatsnew
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* Fix the metadata propagation both in Dataframe.std * Fix the typing problem by forcing propogation only on Series * From judge statement to cast * Add whatsnew
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Fix the metadata propagation both in Dataframe.std * Fix the typing problem by forcing propogation only on Series * From judge statement to cast * Add whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The goal here is to make progress on Various methods don't call call __finalize__ #28283.