Fix the metadata propagation in Dataframe.std (pandas-dev#52924)

* Fix the metadata propagation both in Dataframe.std * Fix the typing problem by forcing propogation only on Series * From judge statement to cast * Add whatsnew
NumanIjaz · May 1, 2023 · ce0a2ae · ce0a2ae
1 parent be13ff6
commit ce0a2ae
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/doc/source/whatsnew/v2.1.0.rst b/doc/source/whatsnew/v2.1.0.rst
@@ -426,6 +426,10 @@ Styler
 - Bug in :meth:`Styler._copy` calling overridden methods in subclasses of :class:`Styler` (:issue:`52728`)
 -
 
+Metadata
+^^^^^^^^
+- Fixed metadata propagation in :meth:`DataFrame.std` (:issue:`28283`)
+
 Other
 ^^^^^
 - Bug in :func:`assert_almost_equal` now throwing assertion error for two unequal sets (:issue:`51727`)

diff --git a/pandas/core/frame.py b/pandas/core/frame.py
@@ -11044,7 +11044,8 @@ def std(
         numeric_only: bool = False,
         **kwargs,
     ):
-        return super().std(axis, skipna, ddof, numeric_only, **kwargs)
+        result = cast(Series, super().std(axis, skipna, ddof, numeric_only, **kwargs))
+        return result.__finalize__(self, method="std")
 
     @doc(make_doc("skew", ndim=2))
     def skew(

diff --git a/pandas/tests/generic/test_finalize.py b/pandas/tests/generic/test_finalize.py
@@ -416,7 +416,6 @@
     ),
     pytest.param(
         (pd.DataFrame, frame_data, operator.methodcaller("std")),
-        marks=not_implemented_mark,
     ),
     pytest.param(
         (pd.DataFrame, frame_data, operator.methodcaller("mean")),