feat: support create3 #3
Conversation
chefburger
force-pushed
the
feat/add-create3-factory
branch
from
4069469
to
c8dfb2a
Compare
chefburger
force-pushed
the
feat/add-create3-factory
branch
from
88188a4
to
a04dbdb
Compare
chefburger
force-pushed
the
feat/add-create3-factory
branch
from
a04dbdb
to
1353edc
Compare
| bytes memory creationCode, | ||
| uint256 creationFund, | ||
| bytes calldata afterDeploymentExecutionPayload, | ||
| uint256 afterDeploymentExecutionFund |
There was a problem hiding this comment.
One suggestion , can we add one parameter about creationCode hash , so we can check whether the creationCode is correct.
For example, we already deployed in one chain , when we tried to deploy same contract in other chains , if we passed wrong creationCode , we will lose chance to deploy with same address.
There was a problem hiding this comment.
For example, we already deployed in one chain , when we tried to deploy same contract in other chains , if we passed wrong creationCode , we will lose chance to deploy with same address.
would adding creationCodeHash works to prevent this?
eg.
-
burger call `create3Factory.deploy("PCS_V4_VAULT", vault.creationCode, keccak256(vault.hash), ...);
-
mist can make the error calling `create3Factory.deploy("PCS_V4_VAULT", clPoolManager.creationCode, keccak256(clPoolManager.hash), ...);
There was a problem hiding this comment.
or can we have a concrete scenario example? thanks
There was a problem hiding this comment.
scenario: when someone is calling create3Factory.deploy directly (not via our v4 deployment script).
Context: new-hire asked to deploy Vault in new chain (arb)
1/ step 1: new-hire see the transaction hash on how vault was deploy on eth
2/ step 2: new-hire copy the params and paste in etherscan calling create3Factory.deploy()
At step 2, somehow the new hire copy-pasted the wrong creation code, and this check will help to protect it
| ) external payable onlyWhitelisted nonReentrant returns (address deployed) { | ||
| deployed = Create3.create3( | ||
| salt, creationCode, creationFund, afterDeploymentExecutionPayload, afterDeploymentExecutionFund | ||
| ); |
There was a problem hiding this comment.
Suggestion: can add deploy event here.
src/Create3Factory.sol
Outdated
| /// @dev ensure this contract is deployed on multiple chain with the same address | ||
| contract Create3Factory is ICreate3Factory, Ownable2Step, ReentrancyGuard { | ||
| event SetWhitelist(address indexed user, bool isWhitelist); | ||
| event Deployed(address indexed deployed, bytes32 salt); |
There was a problem hiding this comment.
can add creationCodeHash here ?
so can verify codehash when tried to deploy in new chains.
chefburger
force-pushed
the
feat/add-create3-factory
branch
from
08425e4
to
5425acf
Compare
No description provided.