feat: clean up / prepare for public repo #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will merge this first and do the last 2 steps soon (once reviewed from security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
remove create2
update README.md
double check on this comment: feat: support create3 #3 (comment)
prep a new EOA deployer
using the EOA deployer, deploy create3Factory on bsc testnet and eth sepolia:
0xCC4cBFD415C6cBC67a94E3e231CEA82D145D08dfverify using create3Factory to deploy Vault works (same address, and owner):
0x7b17Ba70630AD2aC89bfc21e89227087b0810A61vault address on both bsc testnet and sepolia - https://testnet.bscscan.com/address/0x7b17Ba70630AD2aC89bfc21e89227087b0810A61 and https://sepolia.etherscan.io/address/0x7b17Ba70630AD2aC89bfc21e89227087b0810A61using the EOA deployer, deploy create3Factory on bsc/eth mainnet
using the EOA deployer, deploy create3Factory on other chains (arb, base, linea, opbnb, zkevm and zksync)