Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add event_id, batch_id #26

Merged
merged 3 commits into from
Nov 15, 2023
Merged

add event_id, batch_id #26

merged 3 commits into from
Nov 15, 2023

Conversation

webelf101
Copy link
Contributor

@webelf101 webelf101 commented Nov 15, 2023 •
edited by verabehr
Loading

Related Github tickets

fixes VolumeFi/paloma#996

Background

A short paragraph on test what exactly this PR solves.

Testing completed

  • a list of actions that you've performed to ensure that this PR works as intended
  • 99% of the times you should have an item: "wrote tests"

byte-bandit
byte-bandit requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a vyper expert, but if I understand the code correctly, we still need to remove the message_id from the batch submission.

contracts/Compass.vy Outdated Show resolved Hide resolved
contracts/Compass.vy Outdated Show resolved Hide resolved
byte-bandit
byte-bandit approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verabehr verabehr merged commit c860ccb into palomachain:master Nov 15, 2023
1 check passed
@taariq taariq deleted the features/nonces branch November 15, 2023 16:12
@byte-bandit byte-bandit mentioned this pull request Nov 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byte-bandit byte-bandit byte-bandit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URGENT: Update Compass to emit the event nonce for Testnet and Mainnet Proposal 11/14
3 participants
@webelf101 @byte-bandit @verabehr