Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consume event nonce from compass #337

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

byte-bandit
Copy link
Collaborator

@byte-bandit byte-bandit commented Nov 20, 2023

Related Github tickets

Background

This change removes the usage of Paloma governed event nonces when attesting to observed events on target chains. Nonces (now emitted as part of the event data) are still reported to Paloma per observer and cross checked when making a report.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

@byte-bandit
Copy link
Collaborator Author

This works with the updated compass bytecode as verified in private test net. I haven't tested the integration with gravity batches yet, I'm waiting to receive the blueprint address for BNB.

@byte-bandit byte-bandit enabled auto-merge (squash) November 20, 2023 16:21
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@byte-bandit byte-bandit merged commit 33c64b4 into palomachain:master Nov 20, 2023
2 checks passed
@taariq taariq deleted the clohr/gravity-event-nonce branch November 20, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants