Propagate controller action final state #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adolfo-rt @v-lopez please review. |
added 2 commits
February 21, 2014 19:00
controllerCb had no business inside PlayMotion class
So that a proper message can be displayed, and appropriate measures be taken. Fixes #15
|
Refactoring of the pull request done. |
|
Looks good to me. |
|
+1, I saw this working on Friday. |
po1
added a commit
that referenced
this pull request
Feb 24, 2014
Propagate controller action final state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #15
It leaves proper error message and error code generation unimplemented.
Issue #18 has been opened to that effect.